소스 검색

Fix validation message

The check was checking for an empty string in `matrix_jitsi_prosody_auth_internal_accounts`,
which is unlikely to happen. We should check for an empty list instead.

The check was not validating username/password values, so telling the user that they need a non-empty
username/password is misleading. It was merely checking if there's at least one entry in the list.

This patch adjusts the check and message accordingly.
pull/1446/head
Slavi Pantaleev 4 년 전
committed by GitHub
부모
커밋
6568b68759
No known key found for this signature in database GPG 키 ID: 4AEE18F83AFDEB23
1개의 변경된 파일2개의 추가작업 그리고 4개의 파일을 삭제
  1. +2
    -4
      roles/matrix-jitsi/tasks/validate_config.yml

+ 2
- 4
roles/matrix-jitsi/tasks/validate_config.yml 파일 보기

@@ -23,16 +23,14 @@
- name: Fail if a Jitsi internal authentication account is not defined
fail:
msg: >-
Each Jitsi user in `matrix_jitsi_prosody_auth_internal_accounts` needs to have a non-empty `username`/`password`.

Please ensure you have defined at least one user and password when using internal authentication.
At least one Jitsi user needs to be defined in `matrix_jitsi_prosody_auth_internal_accounts` when using internal authentication.
If you're setting up Jitsi for the first time, you may have missed a step.
Refer to our setup instructions (docs/configuring-playbook-jitsi.md).
when:
- matrix_jitsi_enable_auth|bool
- matrix_jitsi_auth_type == 'internal'
- matrix_jitsi_prosody_auth_internal_accounts == ''
- matrix_jitsi_prosody_auth_internal_accounts|length == 0


- name: (Deprecation) Catch and report renamed settings


불러오는 중...
취소
저장