Browse Source

matrix-bridge-mautrix-signal: switch to modern community.docker docker_image modules

Replaces `community.docker.docker_image` with the modern
`docker_image_pull` and `docker_image_build` split modules. Drops the
`ansible_version` compatibility ladder and the now-redundant
`_container_image_force_pull` variable (the new pull module handles
registry refresh natively via `pull: always`). Also registers
`_container_image_build_result` so that a self-build rebuild correctly
triggers a service restart.

Related to https://github.com/spantaleev/matrix-docker-ansible-deploy/issues/5191.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
pull/4219/merge
Slavi Pantaleev 2 days ago
parent
commit
70c4490d64
3 changed files with 10 additions and 13 deletions
  1. +0
    -1
      roles/custom/matrix-bridge-mautrix-signal/defaults/main.yml
  2. +9
    -12
      roles/custom/matrix-bridge-mautrix-signal/tasks/setup_install.yml
  3. +1
    -0
      roles/custom/matrix-bridge-mautrix-signal/tasks/validate_config.yml

+ 0
- 1
roles/custom/matrix-bridge-mautrix-signal/defaults/main.yml View File

@@ -33,7 +33,6 @@ matrix_mautrix_signal_container_image_tag: "{{ matrix_mautrix_signal_version }}"
matrix_mautrix_signal_container_image_registry_prefix: "{{ 'localhost/' if matrix_mautrix_signal_container_image_self_build else matrix_mautrix_signal_container_image_registry_prefix_upstream }}" matrix_mautrix_signal_container_image_registry_prefix: "{{ 'localhost/' if matrix_mautrix_signal_container_image_self_build else matrix_mautrix_signal_container_image_registry_prefix_upstream }}"
matrix_mautrix_signal_container_image_registry_prefix_upstream: "{{ matrix_mautrix_signal_container_image_registry_prefix_upstream_default }}" matrix_mautrix_signal_container_image_registry_prefix_upstream: "{{ matrix_mautrix_signal_container_image_registry_prefix_upstream_default }}"
matrix_mautrix_signal_container_image_registry_prefix_upstream_default: "dock.mau.dev/" matrix_mautrix_signal_container_image_registry_prefix_upstream_default: "dock.mau.dev/"
matrix_mautrix_signal_container_image_force_pull: "{{ matrix_mautrix_signal_container_image.endswith(':latest') }}"


matrix_mautrix_signal_base_path: "{{ matrix_base_data_path }}/mautrix-signal" matrix_mautrix_signal_base_path: "{{ matrix_base_data_path }}/mautrix-signal"
matrix_mautrix_signal_config_path: "{{ matrix_mautrix_signal_base_path }}/config" matrix_mautrix_signal_config_path: "{{ matrix_mautrix_signal_base_path }}/config"


+ 9
- 12
roles/custom/matrix-bridge-mautrix-signal/tasks/setup_install.yml View File

@@ -55,11 +55,9 @@
when: item.when | bool when: item.when | bool


- name: Ensure Mautrix signal image is pulled - name: Ensure Mautrix signal image is pulled
community.docker.docker_image:
community.docker.docker_image_pull:
name: "{{ matrix_mautrix_signal_container_image }}" name: "{{ matrix_mautrix_signal_container_image }}"
source: "{{ 'pull' if ansible_version.major > 2 or ansible_version.minor > 7 else omit }}"
force_source: "{{ matrix_mautrix_signal_container_image_force_pull if ansible_version.major > 2 or ansible_version.minor >= 8 else omit }}"
force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_mautrix_signal_container_image_force_pull }}"
pull: always
when: not matrix_mautrix_signal_container_image_self_build when: not matrix_mautrix_signal_container_image_self_build
register: matrix_mautrix_signal_container_image_pull_result register: matrix_mautrix_signal_container_image_pull_result
retries: "{{ devture_playbook_help_container_retries_count }}" retries: "{{ devture_playbook_help_container_retries_count }}"
@@ -78,16 +76,14 @@
when: "matrix_mautrix_signal_container_image_self_build | bool" when: "matrix_mautrix_signal_container_image_self_build | bool"


- name: Ensure Mautrix signal Docker image is built - name: Ensure Mautrix signal Docker image is built
community.docker.docker_image:
community.docker.docker_image_build:
name: "{{ matrix_mautrix_signal_container_image }}" name: "{{ matrix_mautrix_signal_container_image }}"
source: build
force_source: "{{ matrix_mautrix_signal_git_pull_results.changed if ansible_version.major > 2 or ansible_version.minor >= 8 else omit }}"
force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_mautrix_signal_git_pull_results.changed }}"
build:
dockerfile: Dockerfile
path: "{{ matrix_mautrix_signal_container_src_files_path }}"
pull: true
dockerfile: Dockerfile
path: "{{ matrix_mautrix_signal_container_src_files_path }}"
pull: true
rebuild: "{{ 'always' if matrix_mautrix_signal_git_pull_results.changed | bool else 'never' }}"
when: "matrix_mautrix_signal_container_image_self_build | bool" when: "matrix_mautrix_signal_container_image_self_build | bool"
register: matrix_mautrix_signal_container_image_build_result


- name: Check if an old database file exists - name: Check if an old database file exists
ansible.builtin.stat: ansible.builtin.stat:
@@ -175,6 +171,7 @@
or matrix_mautrix_signal_support_files_result.changed | default(false) or matrix_mautrix_signal_support_files_result.changed | default(false)
or matrix_mautrix_signal_systemd_service_result.changed | default(false) or matrix_mautrix_signal_systemd_service_result.changed | default(false)
or matrix_mautrix_signal_container_image_pull_result.changed | default(false) or matrix_mautrix_signal_container_image_pull_result.changed | default(false)
or matrix_mautrix_signal_container_image_build_result.changed | default(false)
}} }}


- name: Ensure matrix-mautrix-signal.service restarted, if necessary - name: Ensure matrix-mautrix-signal.service restarted, if necessary


+ 1
- 0
roles/custom/matrix-bridge-mautrix-signal/tasks/validate_config.yml View File

@@ -29,6 +29,7 @@
- {'old': 'matrix_mautrix_signal_docker_image_registry_prefix_upstream_default', 'new': 'matrix_mautrix_signal_container_image_registry_prefix_upstream_default'} - {'old': 'matrix_mautrix_signal_docker_image_registry_prefix_upstream_default', 'new': 'matrix_mautrix_signal_container_image_registry_prefix_upstream_default'}
- {'old': 'matrix_mautrix_signal_docker_image_tag', 'new': 'matrix_mautrix_signal_container_image_tag'} - {'old': 'matrix_mautrix_signal_docker_image_tag', 'new': 'matrix_mautrix_signal_container_image_tag'}
- {'old': 'matrix_mautrix_signal_docker_src_files_path', 'new': 'matrix_mautrix_signal_container_src_files_path'} - {'old': 'matrix_mautrix_signal_docker_src_files_path', 'new': 'matrix_mautrix_signal_container_src_files_path'}
- {'old': 'matrix_mautrix_signal_container_image_force_pull', 'new': '<removed> (the new community.docker.docker_image_pull module handles this natively)'}


- name: Fail if required mautrix-signal settings not defined - name: Fail if required mautrix-signal settings not defined
ansible.builtin.fail: ansible.builtin.fail:


Loading…
Cancel
Save