From a0c191811251eed908a5ed32af7478ee396a90a0 Mon Sep 17 00:00:00 2001 From: Suguru Hirahara Date: Sun, 2 Nov 2025 23:39:24 +0900 Subject: [PATCH] Run ansible-lint for files in tasks/ Signed-off-by: Suguru Hirahara --- .../tasks/setup_install.yml | 9 ++++----- .../tasks/setup_uninstall.yml | 1 - .../tasks/validate_config.yml | 5 ++--- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/roles/custom/matrix-bridge-matrixzulipbridge/tasks/setup_install.yml b/roles/custom/matrix-bridge-matrixzulipbridge/tasks/setup_install.yml index b7d0568fc..6d4f9c9db 100644 --- a/roles/custom/matrix-bridge-matrixzulipbridge/tasks/setup_install.yml +++ b/roles/custom/matrix-bridge-matrixzulipbridge/tasks/setup_install.yml @@ -9,7 +9,6 @@ # SPDX-License-Identifier: AGPL-3.0-or-later --- - - name: Ensure MatrixZulipBridge image is pulled community.docker.docker_image: name: "{{ matrix_matrixzulipbridge_docker_image }}" @@ -25,7 +24,7 @@ ansible.builtin.file: path: "{{ item }}" state: directory - mode: 0750 + mode: "0750" owner: "{{ matrix_user_name }}" group: "{{ matrix_group_name }}" with_items: @@ -35,7 +34,7 @@ ansible.builtin.copy: content: "{{ matrix_matrixzulipbridge_registration | to_nice_yaml(indent=2, width=999999) }}" dest: "{{ matrix_matrixzulipbridge_base_path }}/registration.yaml" - mode: 0644 + mode: "0644" owner: "{{ matrix_user_name }}" group: "{{ matrix_group_name }}" @@ -43,7 +42,7 @@ ansible.builtin.template: src: "{{ role_path }}/templates/{{ item }}.j2" dest: "{{ matrix_matrixzulipbridge_base_path }}/{{ item }}" - mode: 0640 + mode: "0640" owner: "{{ matrix_user_name }}" group: "{{ matrix_group_name }}" with_items: @@ -60,4 +59,4 @@ ansible.builtin.template: src: "{{ role_path }}/templates/systemd/matrix-matrixzulipbridge.service.j2" dest: "{{ devture_systemd_docker_base_systemd_path }}/matrix-matrixzulipbridge.service" - mode: 0644 + mode: "0644" diff --git a/roles/custom/matrix-bridge-matrixzulipbridge/tasks/setup_uninstall.yml b/roles/custom/matrix-bridge-matrixzulipbridge/tasks/setup_uninstall.yml index 5c125adc2..bfb53034a 100644 --- a/roles/custom/matrix-bridge-matrixzulipbridge/tasks/setup_uninstall.yml +++ b/roles/custom/matrix-bridge-matrixzulipbridge/tasks/setup_uninstall.yml @@ -6,7 +6,6 @@ # SPDX-License-Identifier: AGPL-3.0-or-later --- - - name: Check existence of matrix-matrixzulipbridge service ansible.builtin.stat: path: "{{ devture_systemd_docker_base_systemd_path }}/matrix-matrixzulipbridge.service" diff --git a/roles/custom/matrix-bridge-matrixzulipbridge/tasks/validate_config.yml b/roles/custom/matrix-bridge-matrixzulipbridge/tasks/validate_config.yml index a0d7cfbac..d8f6b6b75 100644 --- a/roles/custom/matrix-bridge-matrixzulipbridge/tasks/validate_config.yml +++ b/roles/custom/matrix-bridge-matrixzulipbridge/tasks/validate_config.yml @@ -4,12 +4,11 @@ # SPDX-License-Identifier: AGPL-3.0-or-later --- - - name: Fail if required MatrixZulipBridge settings not defined ansible.builtin.fail: msg: >- You need to define a required configuration setting (`{{ item.name }}`). when: "item.when | bool and lookup('vars', item.name, default='') | string | length == 0" with_items: - - {'name': 'matrix_matrixzulipbridge_container_network', when: true} - - {'name': 'matrix_matrixzulipbridge_homeserver_url', when: true} + - { "name": "matrix_matrixzulipbridge_container_network", when: true } + - { "name": "matrix_matrixzulipbridge_homeserver_url", when: true }