diff --git a/roles/custom/matrix-bridge-mautrix-slack/defaults/main.yml b/roles/custom/matrix-bridge-mautrix-slack/defaults/main.yml index 13e85a35d..b983b5664 100644 --- a/roles/custom/matrix-bridge-mautrix-slack/defaults/main.yml +++ b/roles/custom/matrix-bridge-mautrix-slack/defaults/main.yml @@ -23,7 +23,6 @@ matrix_mautrix_slack_container_image: "{{ matrix_mautrix_slack_container_image_r matrix_mautrix_slack_container_image_registry_prefix: "{{ 'localhost/' if matrix_mautrix_slack_container_image_self_build else matrix_mautrix_slack_container_image_registry_prefix_upstream }}" matrix_mautrix_slack_container_image_registry_prefix_upstream: "{{ matrix_mautrix_slack_container_image_registry_prefix_upstream_default }}" matrix_mautrix_slack_container_image_registry_prefix_upstream_default: "dock.mau.dev/" -matrix_mautrix_slack_container_image_force_pull: "{{ matrix_mautrix_slack_container_image.endswith(':latest') }}" matrix_mautrix_slack_base_path: "{{ matrix_base_data_path }}/mautrix-slack" matrix_mautrix_slack_config_path: "{{ matrix_mautrix_slack_base_path }}/config" diff --git a/roles/custom/matrix-bridge-mautrix-slack/tasks/setup_install.yml b/roles/custom/matrix-bridge-mautrix-slack/tasks/setup_install.yml index b7311e16c..35deb7e8c 100644 --- a/roles/custom/matrix-bridge-mautrix-slack/tasks/setup_install.yml +++ b/roles/custom/matrix-bridge-mautrix-slack/tasks/setup_install.yml @@ -49,11 +49,9 @@ when: item.when | bool - name: Ensure Mautrix Slack image is pulled - community.docker.docker_image: + community.docker.docker_image_pull: name: "{{ matrix_mautrix_slack_container_image }}" - source: "{{ 'pull' if ansible_version.major > 2 or ansible_version.minor > 7 else omit }}" - force_source: "{{ matrix_mautrix_slack_container_image_force_pull if ansible_version.major > 2 or ansible_version.minor >= 8 else omit }}" - force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_mautrix_slack_container_image_force_pull }}" + pull: always when: not matrix_mautrix_slack_container_image_self_build register: matrix_mautrix_slack_container_image_pull_result retries: "{{ devture_playbook_help_container_retries_count }}" @@ -72,16 +70,14 @@ when: "matrix_mautrix_slack_container_image_self_build | bool" - name: Ensure Mautrix slack Docker image is built - community.docker.docker_image: + community.docker.docker_image_build: name: "{{ matrix_mautrix_slack_container_image }}" - source: build - force_source: "{{ matrix_mautrix_slack_git_pull_results.changed if ansible_version.major > 2 or ansible_version.minor >= 8 else omit }}" - force: "{{ omit if ansible_version.major > 2 or ansible_version.minor >= 8 else matrix_mautrix_slack_git_pull_results.changed }}" - build: - dockerfile: Dockerfile - path: "{{ matrix_mautrix_slack_container_src_files_path }}" - pull: true + dockerfile: Dockerfile + path: "{{ matrix_mautrix_slack_container_src_files_path }}" + pull: true + rebuild: "{{ 'always' if matrix_mautrix_slack_git_pull_results.changed | bool else 'never' }}" when: "matrix_mautrix_slack_container_image_self_build | bool" + register: matrix_mautrix_slack_container_image_build_result - name: Ensure mautrix-slack config.yaml installed ansible.builtin.copy: @@ -124,6 +120,7 @@ or matrix_mautrix_slack_registration_result.changed | default(false) or matrix_mautrix_slack_systemd_service_result.changed | default(false) or matrix_mautrix_slack_container_image_pull_result.changed | default(false) + or matrix_mautrix_slack_container_image_build_result.changed | default(false) }} - name: Ensure matrix-mautrix-slack.service restarted, if necessary diff --git a/roles/custom/matrix-bridge-mautrix-slack/tasks/validate_config.yml b/roles/custom/matrix-bridge-mautrix-slack/tasks/validate_config.yml index 7594385d3..a0b8b5fc5 100644 --- a/roles/custom/matrix-bridge-mautrix-slack/tasks/validate_config.yml +++ b/roles/custom/matrix-bridge-mautrix-slack/tasks/validate_config.yml @@ -23,6 +23,7 @@ - {'old': 'matrix_mautrix_slack_docker_image_registry_prefix_upstream', 'new': 'matrix_mautrix_slack_container_image_registry_prefix_upstream'} - {'old': 'matrix_mautrix_slack_docker_image_registry_prefix_upstream_default', 'new': 'matrix_mautrix_slack_container_image_registry_prefix_upstream_default'} - {'old': 'matrix_mautrix_slack_docker_src_files_path', 'new': 'matrix_mautrix_slack_container_src_files_path'} + - {'old': 'matrix_mautrix_slack_container_image_force_pull', 'new': ' (the new community.docker.docker_image_pull module handles this natively)'} - name: Fail if required mautrix-slack settings not defined ansible.builtin.fail: